Instrument All Redis Client Methods #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Uma Annamalai <[email protected]> Co-authored-by: ccedacero-nr <[email protected]> Co-authored-by: Nyenty Ayuk <[email protected]>
MegaLinter status: ❌ ERROR
See errors details in artifact MegaLinter reports on CI Job page |
umaannamalai
approved these changes
Jun 24, 2022
| "response_callbacks", | ||
| "RESPONSE_CALLBACKS", | ||
| "sentinel", | ||
| "sentinel", |
There was a problem hiding this comment.
Is "sentinel" supposed to be an ignored method and in the redis_client_methods list? It is in this list twice as well
umaannamalai
approved these changes
Jun 27, 2022
TimPansino
added a commit
that referenced
this pull request
Jun 28, 2022
* Add aioredis Instrumentation (#567) * Add aioredis instrumentation Co-authored-by: Uma Annamalai <[email protected]> Co-authored-by: Nyenty Ayuk <[email protected]> Co-authored-by: ccedacero-nr <[email protected]> * [Mega-Linter] Apply linters fixes * Bump Tests * Fix double wrapping Co-authored-by: Uma Annamalai <[email protected]> Co-authored-by: Nyenty Ayuk <[email protected]> Co-authored-by: ccedacero-nr <[email protected]> Co-authored-by: TimPansino <[email protected]> * Add aioredis test infrastructure. (#568) * Add aioredis test infra. * Fix flake8 errors. * Aredis concurrency bug reproduction. (#569) Co-authored-by: Uma Annamalai <[email protected]> Co-authored-by: Uma Annamalai <[email protected]> * Add aioredis tests (#573) * Add get and set tests. * Add more testing for aioredis. * Add aioredis testing. Co-authored-by: Tim Pansino <[email protected]> Co-authored-by: Cristian Cedacero <[email protected]> Co-authored-by: Nyenty Ayuk-Enow <[email protected]> * Patch broken tests * Final aioredis testing cleanup Co-authored-by: Nyenty Ayuk <[email protected]> Co-authored-by: ccedacero-nr <[email protected]> Co-authored-by: Uma Annamalai <[email protected]> * Parametrize multiple db tests. * Add missing arg. * Fix typo. * Add missing comma. * Add background_task decorator. * Parametrize instance info tests. * Fix formatting Co-authored-by: Tim Pansino <[email protected]> Co-authored-by: Cristian Cedacero <[email protected]> Co-authored-by: Nyenty Ayuk-Enow <[email protected]> Co-authored-by: Tim Pansino <[email protected]> Co-authored-by: ccedacero-nr <[email protected]> Co-authored-by: Uma Annamalai <[email protected]> Co-authored-by: Timothy Pansino <[email protected]> * Fix AIORedis Concurrency Bug (#574) * Add test for concurrency bug * Fix aioredis concurrency * Fix func signature * Fix ARedis Concurrency Bug (#570) * Patch aredis concurrency bug * Remove xfail marker * Format * Move fixture import Co-authored-by: Uma Annamalai <[email protected]> * Increase concurrency of redis tests (#575) * Instrument All Redis Client Methods (#576) * Initial test files * Fully instrument uninstrumented redis client methods Co-authored-by: Uma Annamalai <[email protected]> Co-authored-by: ccedacero-nr <[email protected]> Co-authored-by: Nyenty Ayuk <[email protected]> * Fix older redis client tests * Fix missing redis client method * Remove sentinel from commands list * Fix sentinels again Co-authored-by: Uma Annamalai <[email protected]> Co-authored-by: ccedacero-nr <[email protected]> Co-authored-by: Nyenty Ayuk <[email protected]> * Add aioredis v1 support (#579) * Add aioredis v1 tests * Fix aioredis v1 Co-authored-by: Uma Annamalai <[email protected]> * Adjust multiple dbs tests * Fix megalinter default base * Fix megalinter base take two * Fix aioredis version parser * Uncomment instance info tests * Fix import issues Co-authored-by: Uma Annamalai <[email protected]> Co-authored-by: Timothy Pansino <[email protected]> Co-authored-by: Uma Annamalai <[email protected]> Co-authored-by: Nyenty Ayuk <[email protected]> Co-authored-by: ccedacero-nr <[email protected]> Co-authored-by: TimPansino <[email protected]> Co-authored-by: Tim Pansino <[email protected]> Co-authored-by: Cristian Cedacero <[email protected]> Co-authored-by: Tim Pansino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview